[SPIGOT-4819] Spawning Arrow entities improperly tips them with water Created: 30/Apr/19  Updated: 30/Apr/19  Resolved: 30/Apr/19

Status: Resolved
Project: Spigot
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Bug Priority: Minor
Reporter: Mick Monkey Assignee: Unassigned
Resolution: Fixed Votes: 0
Labels: 1.14, bukkit

Version: git-Spigot-c529d43-9926d78 (MC: 1.14) (Implementing API version 1.14-R0.1-SNAPSHOT)
Guidelines Read: Yes

 Description   

This commit: https://hub.spigotmc.org/stash/projects/SPIGOT/repos/bukkit/commits/67d908a9830c71267ee740f5bddd728ce9c64cc7#src/main/java/org/bukkit/entity/EntityType.java
removed the "TIPPED_ARROW" entity type, and changed ARROW to be a reference to TippedArrow. They are still separate types internally, and should still both be available. These are indeed now separate types internally, however the spawning logic should be updated to reflect that an "Arrow" is normally just an arrow, not a tipped arrow (until a tip is added).
The world#spawnArrow method will allow correctly spawning them separately using Arrow.class and TippedArrow.class ... the world#spawnEntity method, when fed EntityType.ARROW, will spawn an arrow that contains an invalid tip. When picked up, such arrows will display as "Arrow of Splashing" (a tipped arrow item with no potion effect to apply). They visible give off a water-blue potion particle.
The correct behavior of course should be not having any tip until/unless a potion tip is set.

 Comments   
Comment by Mick Monkey [ 30/Apr/19 ]

Actually yes, on closer review the NMS code does treat them as a single entity type now. Will update the issue accordingly.

Comment by md_5 [ 30/Apr/19 ]

Mcwiki disagrees with you that they are separate types, as does the code last time I looked at it

http://minecraft.gamepedia.com/Entity

 

Pretty sure the bug is invalid tipping, not the type being missing

 

Generated at Tue Apr 15 09:41:44 UTC 2025 using Jira 10.3.3#10030003-sha1:d220e3fefc8dfc6d47f522d3b9a20c1455e12b7b.