[SPIGOT-4400] Custom populators running on existing chunks Created: 27/Sep/18 Updated: 27/Sep/18 Resolved: 27/Sep/18 |
|
Status: | Resolved |
Project: | Spigot |
Component/s: | None |
Affects Version/s: | None |
Fix Version/s: | None |
Type: | Bug | Priority: | Minor |
Reporter: | XerxesTireIron | Assignee: | Unassigned |
Resolution: | Fixed | Votes: | 0 |
Labels: | 1.13, chunk |
Attachments: |
![]() ![]() |
Version: | git-Spigot-f6a273b-1a7f2d1 (MC: 1.13.1) (Implementing API version 1.13.1-R0.1-SNAPSHOT) |
Guidelines Read: | Yes |
Description |
The first time an existing chunk from an older world is loaded in 1.13 (by player or plugin), custom block populators that are currently active will be run as though it were a brand new chunk being generated. This causes an unwanted retrogen that can destroy player content. Vanilla populators are not run, only the ones added by plugin. If --forceUpgrade has been used on the world beforehand the problem still occurs. If a chunk has already been loaded at least once in 1.13, the populators do not fire during future loads of the chunk. Edit: The world test1 was generated under 1.12.2 with no plugins and has not been converted to 1.13 yet. With a default config, the plugin GiantCaves will generate large caves that can be found at x:250 y:25 z:400 and x:100 y:20 z:700. Both locations are part of the already generated terrain and should not have those caves forming. The code for GiantCaves can be found here: https://github.com/OtakuMegane/GiantCaves |
Comments |
Comment by md_5 [ 27/Sep/18 ] |
I think this is fixed, but please try and provide a more minimal test case in future |
Comment by XerxesTireIron [ 27/Sep/18 ] |
Apologies for that, will be more thorough in the future. I've attached a test world and the plugin I first noticed this happening with. |
Comment by md_5 [ 27/Sep/18 ] |
Can you try following the bug report guidelines you said you read please. i.e. attach a world and plugin that shows the issue |