SkullTest.jar
[SPIGOT-4224] block.CraftBlockState cannot be cast to org.bukkit.block.Skull Created: 03/Aug/18 Updated: 03/Aug/18 Resolved: 03/Aug/18 |
|
| Status: | Resolved |
| Project: | Spigot |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Bug | Priority: | Minor |
| Reporter: | xtomyserrax | Assignee: | Unassigned |
| Resolution: | Won't Fix | Votes: | 0 |
| Labels: | bug, getState, legacy, skull | ||
| Environment: |
I am using Java 8 and Windows 10 |
||
| Attachments: |
SkullTest.jar
|
| Version: | This server is running CraftBukkit version git-Spigot-69774b3-671581e (MC: 1.13) (Implementing API version 1.13-R0.1-SNAPSHOT) |
| Plugin: | SkullTest |
| Guidelines Read: | Yes |
| Description |
|
Hey, I have found a problem with legacy. I have a plugin which sets a skull block in a player's position. This skull is well generated in 1.12.2 but when I use the same plugin in 1.13 it doesnt work. I will attach code, console error and a small reproduction plugin in which with just using /skulltest you will notice what is going wrong. Console Error: https://paste.md-5.net/fotewixovo.profile Command Code: https://paste.md-5.net/fimehivoca.avrasm The line giving error is this one: Skull skull = (Skull) loc.getBlock().getState();
Aparently the plugin in 1.13 cant get the state of that skull block. Nothing to reproduce, just use the command /skulltest if you want to see, if not, you have the ConsoleError.
Wish this helps you to keep improving the amazing Legacy system you made and to let skull plugins keep alive!
Thank you. Wish I have been clear, if not, sorry and dont hesitate to ask. |
| Comments |
| Comment by md_5 [ 03/Aug/18 ] |
|
There is no easy way this code can be made to work, because skulls were broken up into different blocks. The converter would have to do weird stuff like take (1.13 skeleton skull, 3) and turn it into a player skull, which is not within the scope of the converter, since that is now mixing 1.13 and data values which don't exist. This is because your original setType call does not have to context it needs to map the material into a player skull. Even if that part succeeded, skull.setSkullType(SkullType.PLAYER) would fail anyway because that method makes no sense in 1.13, so your plugin would still have to be updated. |
| Comment by Black Hole [ 03/Aug/18 ] |
|
In 1.13 only player heads have a special BlockState. I don't think it'll be possible to create the Skull-BlockSate for legacy plugins. |