[SPIGOT-4116] Command suggestions causes kicked for spamming Created: 23/Jul/18 Updated: 29/Aug/18 Resolved: 23/Jul/18 |
|
| Status: | Resolved |
| Project: | Spigot |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Bug | Priority: | Minor |
| Reporter: | Daniel Friedrich | Assignee: | Unassigned |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | 1.13, Essentials, kicked | ||
| Environment: |
Java 8 |
||
| Version: | This server is running CraftBukkit version git-Spigot-5eb3921-b50bb15 (MC: 1.13) (Implementing API version 1.13-R0.1-SNAPSHOT) |
| Plugin: | Essentials |
| Description |
|
This bug only occurs on spigot, vanilla commands don't cause this. I initially discovered this when players where kicked for spam while messaging each other (using Essentials) despite messages being infrequent (10 seconds apart) and containing different text. Server operators are not affected by this bug. Steps to recreate this bug from a clean install of Spigot 1.13 with no plugins:
This bug also occurs while typing out any sort of message command with small words, such as typing long messages in /msg with Essentials. It only happened with longer messages that were about a sentence in length or at least 12 words, and did not occur when using the up key to repeat a previous message. After each word I type, it gives a suggestion of the current online players. Perhaps this queries the server and is what is causing the spam. Could there be a way to disable this command suggestion for plugin commands while the user is typing out the command, or go back to the 1.12 method of tab completion? Even if I turn off command suggestions in the minecraft client, this bug still occurs. |
| Comments |
| Comment by md_5 [ 29/Aug/18 ] |
|
I've tweaked it again, since the client appears to be duplicating packets. |
| Comment by Wafloon [ 29/Aug/18 ] |
|
Reproduced on version git-Spigot-2440e18-3831ae6 (1.13.1). |
| Comment by DrBot [ 29/Aug/18 ] |
|
I had this isse as well. It was fixed after you doubled the threshold, but ever since I updated to the spigot 1.13.1 snapshots, the bug is back. |
| Comment by md_5 [ 23/Jul/18 ] |
|
I've tweaked the threshold to be more than twice what it previously was. |