Screen Shot 2018-07-16 at 09.19.04.png
Screen Shot 2018-07-16 at 09.27.41.png
[SPIGOT-4017] Team prefix/suffix limited to 16 characters on 1.13 Created: 16/Jul/18 Updated: 17/Jul/18 Resolved: 16/Jul/18 |
|
| Status: | Resolved |
| Project: | Spigot |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Bug | Priority: | Minor |
| Reporter: | Niall | Assignee: | Unassigned |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | Scoreboard, Teams | ||
| Environment: |
git-Spigot-4520628-e563bc0 (MC: 1.13-pre7) (Implementing API version 1.13-pre7-R0.1-SNAPSHOT) |
||
| Attachments: |
Screen Shot 2018-07-16 at 09.19.04.png
Screen Shot 2018-07-16 at 09.27.41.png
|
| Version: | 1.13-pre7 |
| Description |
|
There is a limit present on the amount of characters in prefix/suffix. This limit is not present in vanilla 1.13. Although Im assuming this is for a compatibility layer with the older clients that only handle 16 characters.
If theres any update on this that would be great
|
| Comments |
| Comment by Lorenzo Lapucci [ 17/Jul/18 ] |
|
We could use the prefix for every kind of text without using some substring and lastColor tricks if we didn't have this limitation, making it configurable in bukkit.yml and/or using API methods? In this way plugins will be able to edit the limit without any problem |
| Comment by Niall [ 16/Jul/18 ] |
|
Well those limits are fine for me. But really its what you think is appropriate. I wouldn't mind it higher, as I don't use displaynames as part of the scoreboard so I'm limited to the 64 chars, but I think thats fine. |
| Comment by md_5 [ 16/Jul/18 ] |
|
Each, hence the 128 char total. We don't care about 1.12/ other versions, but we to have a concrete limit for API predictability. |
| Comment by Niall [ 16/Jul/18 ] |
|
Those are reasonable limits. 32 characters for prefix/suffix sounds good but It would be nice if we could bump that up to maybe 64. I'm also thinking about if a plugin goes to set the prefix with 32 characters for a 1.12 client causing a crash. There would probably need to a be checks in place for different client versions. Thanks |
| Comment by md_5 [ 16/Jul/18 ] |
|
Was waiting for this. What do you want the limit to be? Is 32 for prefix/suffix and 64 for displayName sufficient? That gives you 128 characters to work with in the scoreboard which is surely enough for reasonable use cases. There technically is a limit, it's just not very well defined because the limit is on the converted JSON. |
