[SPIGOT-3522] Add method to force load skin data in SkullMeta Created: 18/Aug/17 Updated: 13/Feb/22 Resolved: 13/Feb/22 |
|
| Status: | Resolved |
| Project: | Spigot |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | New Feature | Priority: | Minor |
| Reporter: | Alvin Larsson Bringholm | Assignee: | Unassigned |
| Resolution: | Fixed | Votes: | 1 |
| Labels: | skin, skull | ||
| Description |
|
I propose that a method to force load skin data would be added in the SkullMeta class. Because as of now, if you set the Owner to one that has not yet been loaded, it will simply display as the default skin. The only way to currently correct this is to either use NMS or to place the skull down in the World. What I suggest is adding a method to the SkullMeta class to force load the skin data if it's not already present. This could be done (in 1.12.1) using the TileEntitySkull#b(GameProfile, Predicate) method. I understand there would be complications due to the fact that the data is loaded async, but maybe a callback system could be implemented? |
| Comments |
| Comment by Marvin Rieple [ 13/Feb/22 ] |
|
With the addition of the PlayerProfile api in 1.18.1 you can use the PlayerProfile#update() method to load the profile / texture before applying it to a skull. |
| Comment by Alvin Larsson Bringholm [ 19/Aug/17 ] |
|
Actually, I realize now, that this functionality is somewhat implemented on Spigot, but not on CraftBukkit (I also now see that the TileEntitySkull async system is actually patched in by Spigot). Pardon my mistakes of being uninformed. Can I change my suggestion to instead be this: Make the functionality be the same on both CraftBukkit (because as of now SkullMeta doesn't even work on CraftBukkit) and Spigot, and then implement a mechanism to have a callback from the async system so a user can be sure when the skin data has been retrieved. |