[SPIGOT-3257] NullPointerException when revoking advancement from function Created: 20/May/17 Updated: 21/May/17 Resolved: 21/May/17 |
|
| Status: | Resolved |
| Project: | Spigot |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Bug | Priority: | Minor |
| Reporter: | Zedadias Wick | Assignee: | Unassigned |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | advancement, command, function, nullpointerexception | ||
| Description |
|
I see an error when revoking an advancement from a function rewarded by the same advancement.
I have the following in the function: utility/my_function.mcfunction
say I am in location! advancement revoke Zedwick only utility:my_advancement and the following in an advancement at utility/my_advancement.json {
"rewards":
{
"function": "utility:my_function"
}, "display":
{
"hidden": true,
"announce_to_chat": false,
"show_toast": false,
"icon":
{
"item": "minecraft:log"
},
"title": "A Location",
"frame": "task",
"description": "You are in the location!"
},
"parent": "zedwork:lvs/root",
"criteria":
{
"the_location":
{
"trigger": "minecraft:location",
"conditions":
{
"position":
{
"x":
{
"max": 10000,
"min": -10000
},
"y":
{
"max": 256,
"min": 0
}, "z":
{
"max": 10000,
"min": -10000
}
}
}
}
}
}
with the following in utility/root.json {
"display":
{
"description": "You shouldn't be able to see these…",
"icon":
{
"item": "minecraft:double_plant"
},
"title": "My Utility",
"background": "minecraft:textures/gui/advancements/backgrounds/stone.png"
},
"criteria":
{
"utility":
{
"trigger": "minecraft:impossible"
}
}
}
Which appears to work perfectly, however I see the following in the chat after each execution: [00:11:40 INFO]: [§dZedwick§r] I am in location! [00:11:40 WARN]: Couldn't process command: advancement revoke Zedwick only utility:my_advancement java.lang.NullPointerException: null at net.minecraft.server.v1_12_R1.AdvancementRewards$1.getSendCommandFeedback(SourceFile:127) ~[plugz.jar:git-Spigot-6629162-cda27c9] at net.minecraft.server.v1_12_R1.CommandDispatcher.a(CommandDispatcher.java:87) ~[plugz.jar:git-Spigot-6629162-cda27c9] at net.minecraft.server.v1_12_R1.CommandAbstract.a(SourceFile:673) ~[plugz.jar:git-Spigot-6629162-cda27c9] at net.minecraft.server.v1_12_R1.CommandAbstract.a(SourceFile:668) ~[plugz.jar:git-Spigot-6629162-cda27c9] at net.minecraft.server.v1_12_R1.CommandAdvancement$Filter.a(SourceFile:336) ~[plugz.jar:git-Spigot-6629162-cda27c9] at net.minecraft.server.v1_12_R1.CommandAdvancement.a(SourceFile:103) ~[plugz.jar:git-Spigot-6629162-cda27c9] at net.minecraft.server.v1_12_R1.CommandAdvancement.execute(SourceFile:53) ~[plugz.jar:git-Spigot-6629162-cda27c9] at net.minecraft.server.v1_12_R1.CommandHandler.a(SourceFile:92) [plugz.jar:git-Spigot-6629162-cda27c9] at net.minecraft.server.v1_12_R1.CommandHandler.a(SourceFile:70) [plugz.jar:git-Spigot-6629162-cda27c9] at net.minecraft.server.v1_12_R1.CustomFunction$b.a(SourceFile:60) [plugz.jar:git-Spigot-6629162-cda27c9] at net.minecraft.server.v1_12_R1.CustomFunctionData$a.a(CustomFunctionData.java:170) [plugz.jar:git-Spigot-6629162-cda27c9] at net.minecraft.server.v1_12_R1.CustomFunctionData.a(CustomFunctionData.java:108) [plugz.jar:git-Spigot-6629162-cda27c9] at net.minecraft.server.v1_12_R1.AdvancementRewards.a(SourceFile:140) [plugz.jar:git-Spigot-6629162-cda27c9] at net.minecraft.server.v1_12_R1.AdvancementDataPlayer.grantCriteria(AdvancementDataPlayer.java:204) [plugz.jar:git-Spigot-6629162-cda27c9] at net.minecraft.server.v1_12_R1.CriterionTrigger$a.a(SourceFile:31) [plugz.jar:git-Spigot-6629162-cda27c9] at net.minecraft.server.v1_12_R1.CriterionTriggerLocation$a.a(SourceFile:121) [plugz.jar:git-Spigot-6629162-cda27c9] at net.minecraft.server.v1_12_R1.CriterionTriggerLocation.a(SourceFile:72) [plugz.jar:git-Spigot-6629162-cda27c9] at net.minecraft.server.v1_12_R1.EntityPlayer.playerTick(EntityPlayer.java:367) [plugz.jar:git-Spigot-6629162-cda27c9] at net.minecraft.server.v1_12_R1.PlayerConnection.e(PlayerConnection.java:138) [plugz.jar:git-Spigot-6629162-cda27c9] at net.minecraft.server.v1_12_R1.NetworkManager.a(NetworkManager.java:233) [plugz.jar:git-Spigot-6629162-cda27c9] at net.minecraft.server.v1_12_R1.ServerConnection.c(ServerConnection.java:140) [plugz.jar:git-Spigot-6629162-cda27c9] at net.minecraft.server.v1_12_R1.MinecraftServer.D(MinecraftServer.java:842) [plugz.jar:git-Spigot-6629162-cda27c9] at net.minecraft.server.v1_12_R1.DedicatedServer.D(DedicatedServer.java:405) [plugz.jar:git-Spigot-6629162-cda27c9] at net.minecraft.server.v1_12_R1.MinecraftServer.C(MinecraftServer.java:678) [plugz.jar:git-Spigot-6629162-cda27c9] at net.minecraft.server.v1_12_R1.MinecraftServer.run(MinecraftServer.java:576) [plugz.jar:git-Spigot-6629162-cda27c9] at java.lang.Thread.run(Thread.java:745) [?:1.8.0_45]
|
| Comments |
| Comment by md_5 [ 21/May/17 ] |
|
Sounds like a vanilla issue, you should test vanilla |