[SPIGOT-318] BlockRedstoneEvent is not always fired! Created: 30/Dec/14  Updated: 08/Mar/15  Resolved: 08/Mar/15

Status: Closed
Project: Spigot
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Bug Priority: Major
Reporter: Axel Assignee: md_5
Resolution: Won't Fix Votes: 4
Labels: blocks, bug, event, redstone
Environment:

Windows 7 64 bits



 Description   

On this picture, the block contained in the BlockRedstoneEvent is the one i'm standing on. But there's not even fired for the one i'm looking at, or normally this block is powered by redstone

As you can see on this screenshot :

The event.getBlock() function gives me the block i'm standing on. That's not normal, the event should be fired for the one i'm looking at.
Please, I really need this event to work for my plugin.

It's the same on Craftbukkit btw.



 Comments   
Comment by Thinkofname [ 08/Mar/15 ]

Unless the author of the issue still plans on submitting a PR to fix this I assume it isn't an issue anymore? You could work around by listen for the redstone events for surrounding redstone and look for nearby signs if this is still an issue

Comment by Axel [ 24/Jan/15 ]

Okay, i understand there's a lot to do with craftbukkit. I'll do what i can.

Comment by md_5 [ 24/Jan/15 ]

Find out where to add it and we'll add it. BlockSign isn't the correct place though.

Comment by Axel [ 24/Jan/15 ]

Uuuh sorry i didn't read your comment correctly Thinkofdeath
So there's no possibility to add it?
I suppose we can't directly mod the NMS ?

Comment by md_5 [ 16/Jan/15 ]

There is no patch because there is no doPhysics in BlockSign as of 1.8 licks92
Unfortunately we can't really provide help getting your plugin to work unless you help us, redstone is complicated. Can signs even be powered anymore....

Comment by Mario Chiesa [ 16/Jan/15 ]

Hi,
I don't want to intrude on the back and forth comments to try and fix this plugin with you three but
is there any movement to get this figured out and fixed?
Great plugin and very useful, I'd like to see it updated and something I can use for my server again.

Thanks and much appreciated.

Comment by Axel [ 08/Jan/15 ]

I'm sorry, should have put a sign in the screenshot. The thing is : in craftbukkit for mc 1.7, the BlockSign did send a BlockRedstoneEvent. Now it's not the case.
I have to admit I should make a new issue, but I think I explained here what's wrong.
Of course not all the blocks are supposed to send this event, but the sign should.

Thinkofdeath : I see that. But why is there no patch (in the fodler nms-patches on stash) that adds the BlockRedstoneEvent in this class?

Comment by Thinkofname [ 08/Jan/15 ]

licks92 http://hastebin.com/habojatuxo.java this is the 1.8 sign class, all the physics handling it had before has been removed

Comment by md_5 [ 07/Jan/15 ]

That code only covers signs, I don't see a sign in the screenshot?

Comment by Axel [ 07/Jan/15 ]

Well actually... i am the dev of Wredstone.
That's why I searched in your code to find what's wrong, and I found it. Explained it a few comments ago

Comment by md_5 [ 06/Jan/15 ]

Have you considered asking the wireless redstone dev to chip in? The redstone code is a clusterf***.

Comment by Alexander MacKelly [ 03/Jan/15 ]

Hopefully this gets fixed soon. Wireless redstone is an amazing mod. Keeps my builds looking clean and uncluttered.

Comment by Axel [ 03/Jan/15 ]

Oh, and that makes this problem restricted to BlockSign.

Comment by Axel [ 03/Jan/15 ]

I'm here to give the solution!

I realized on your stash that there's no patch for the BlockSign class : https://hub.spigotmc.org/stash/projects/SPIGOT/repos/craftbukkit/browse/nms-patches

Please, I beg you to hurry and simply add what's needed. This code is very simple, you can even find it here :
https://github.com/Wolf-in-a-bukkit/Craftbukkit/blob/master/src/main/java/net/minecraft/server/BlockSign.java
Line 117. There are 7 lines to take and add in your project.
If you do this, my plugin will work perfectly.
I give you cookies in advance !!!

Generated at Sat Dec 13 15:23:49 UTC 2025 using Jira 10.3.13#10030013-sha1:56dd970ae30ebfeda3a697d25be1f6388b68a422.