[SPIGOT-2474] Removing fish hook in PlayerFishEvent causes all future PlayerFishEvents to break Created: 01/Jul/16  Updated: 02/Jul/16  Resolved: 02/Jul/16

Status: Resolved
Project: Spigot
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Bug Priority: Minor
Reporter: BillyGalbreath Assignee: Unassigned
Resolution: Fixed Votes: 0
Labels: None


 Description   

Code used to recreate:
http://paste.md-5.net/mojayimobi.coffee

The example will stop players from pulling armor stands using fishing poles. It works as intended until I remove the hook from the armorstand/world.

After the hook has been removed all future PlayerFishEvents cancel out the exact same way. Meaning, after I try to pull an armor stand I cant even throw/cast the fishing line back out in a lake/ocean somewhere else. Its immediately cancelled.



 Comments   
Comment by BillyGalbreath [ 01/Jul/16 ]

I'm unable to update the ticket, so here:

I updated the test code to include some debug information: http://paste.md-5.net/waxefurixa.coffee

This is a screenshot of the debug output with the remove() line commented out (works as intended): http://prnt.sc/bni0aj

This is a screenshot of the debug output with the remove() line in tact (broken as hell): http://prnt.sc/bni14v

Generated at Mon Mar 31 18:08:24 UTC 2025 using Jira 10.3.3#10030003-sha1:d220e3fefc8dfc6d47f522d3b9a20c1455e12b7b.