[SPIGOT-2176] Missing potion effects after Potion.fromItemStack Created: 12/Apr/16  Updated: 13/Apr/16  Resolved: 13/Apr/16

Status: Resolved
Project: Spigot
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Bug Priority: Minor
Reporter: noX Assignee: Unassigned
Resolution: Invalid Votes: 0
Labels: 1.9, bug, potion, potioneffect, spigot


 Description   

I have an ItemStack of a potion with some PotionEffect on it.
If I use Potion.fromItemStack(itemstack), it results in a Potion object without any effects (potion.getEffects() is an empty list).

 Comments   
Comment by md_5 [ 13/Apr/16 ] 
/**
 * Potion Adapter for pre-1.9 data values
 * see @PotionMeta for 1.9+
 */
@Deprecated
public class Potion {

This class is not meant to be used.

Comment by noX [ 13/Apr/16 ]

Here you go:

// Create potion
ItemStack itemstack = new ItemStack(Material.POTION, 1);
PotionMeta meta = (PotionMeta) itemstack.getItemMeta();
meta.addCustomEffect(new PotionEffect(PotionEffectType.JUMP, 10, 0), true);
itemstack.setItemMeta(meta);
			
// Lookup effects
Potion potion = Potion.fromItemStack(itemstack);
PotionMeta meta = (PotionMeta) itemstack.getItemMeta();
System.err.println("effects of Potion: " + potion.getEffects().size());
System.err.println("effects of PotionMeta: " + meta.getCustomEffects().size());
Comment by md_5 [ 12/Apr/16 ]

Please provide reproduction code for both creation of ItemStack and retrieval.

Generated at Thu Apr 03 15:54:46 UTC 2025 using Jira 10.3.3#10030003-sha1:d220e3fefc8dfc6d47f522d3b9a20c1455e12b7b.