[SPIGOT-207] GSON gets relocated unlike most of the other libraries Created: 13/Dec/14  Updated: 11/Dec/17  Resolved: 11/Mar/15

Status: Closed
Project: Spigot
Component/s: None
Affects Version/s: None
Fix Version/s: Spigot 1.8.3

Type: New Feature Priority: Minor
Reporter: MineDev2014 Assignee: Thinkofname
Resolution: Fixed Votes: 3
Labels: 1.8


 Description   

(None of the issue types really fit, this is more an improvement than a bug or new feature...)

Prior to 1.8, the libraries used by Minecraft were located in the net.minecraft.util package, so for example net.minecraft.util.io.netty or net.minecraft.util.com.google.gson. In 1.8 these were removed and merged to their default pacakage instead. Now we have packages like io.netty or a newer Guava version directly.

The GSON library was also removed from there, but unlike the others it is not included in the default package. CraftBukkit has always included a copy of GSON, in org.bukkit.craftbukkit.libs.com.google.gson. Because it gets relocated in CraftBukkit, Minecraft will also use GSON in the other package instead.

You should either have all libraries in a different package, or all of them in default package. This inconsistency makes it harder for plugin authors for example to make plugins that will run on different implementations, e.g. Spigot and BungeeCord because the GSON package is in a different package.

GSON is a very nice library, I don't see any reason why you couldn't add it to Bukkit for example. This would be really nice and useful for a lot of developers.

 Comments   
Comment by FearThe1337 [ 13/Dec/14 ]

[23:57:16] <~md_5> it will be fixed when we release 1.8.1
[23:57:25] <~md_5> Because that will break NMS / OBC anyway
[23:57:30] <~md_5> gson is currently classed as that

So most likely this will not be fixed for a while.

Comment by FlashLight34 [ 13/Dec/14 ]

yes this broke fanciful im very sad

Comment by MineDev2014 [ 13/Dec/14 ]

Guava was broken this release, if we ever want to do it we should do it now, before it is too late already. There won't be a lot of plugins breaking on this (yet). ProtocolLib will need a small update, but other than that...

Comment by GotoFinal [ 13/Dec/14 ]

I was asking about that some time ago... and this is mistake.
But... I think that it's too late to fix it. That would be a breaking change.

Generated at Thu Apr 03 13:32:38 UTC 2025 using Jira 10.3.3#10030003-sha1:d220e3fefc8dfc6d47f522d3b9a20c1455e12b7b.