0031-Fixed-door-direction-mask.patch
[SPIGOT-1393] Door setFacingDirection using wrong bit mask Created: 03/Jan/16 Updated: 01/Jul/16 Resolved: 01/Jul/16 |
|
| Status: | Resolved |
| Project: | Spigot |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Bug | Priority: | Minor |
| Reporter: | Ryan Bennitt | Assignee: | Unassigned |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | bug, bukkit | ||
| Attachments: |
0031-Fixed-door-direction-mask.patch
|
| Description |
|
The Door class is using the bitmask 0x12 to merge existing block data with the new direction. It should be using 0xC (decimal 12). |
| Comments |
| Comment by md_5 [ 01/Jul/16 ] |
|
Assuming this was fixed by the associated PR |
| Comment by Ryan Bennitt [ 11/Jan/16 ] |
|
Committed standalone fix and created pull request on Bukkit master. |
| Comment by Ryan Bennitt [ 11/Jan/16 ] |
|
How do I go from having created a patch with rebuildPatches.sh to committing this against the Bukkit branch? |
| Comment by Ryan Bennitt [ 10/Jan/16 ] |
|
I have access! Created pull request for master. |
| Comment by Ryan Bennitt [ 03/Jan/16 ] |
|
Fixed bitmask in setFacingDirection Also added convenience constructors for correctly creating the bottom and top half of the door with the correct settings. Improved javadoc Added material data unit tests for all door types. |
| Comment by SpigotMC [ 03/Jan/16 ] |
|
Your build is not the latest and therefore may be the reason you are having this issue. Spigot is 0 version(s) behind. CraftBukkit is 1 version(s) behind. This message was automatically generated and is not guaranteed to be a solution to your issue. |