[BUILDTOOLS-550] compiling CraftBukkit still applies spigot patches Created: 11/Sep/20  Updated: 06/Feb/24  Resolved: 06/Feb/24

Status: Resolved
Project: BuildTools
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Improvement Priority: Minor
Reporter: Jan Boerman Assignee: Unassigned
Resolution: Fixed Votes: 0
Labels: craftbukkit
Environment:

java version "14" 2020-03-17
Java(TM) SE Runtime Environment (build 14+36-1461)
Java HotSpot(TM) 64-Bit Server VM (build 14+36-1461, mixed mode, sharing)

git version 2.28.0.windows.1

Attachments: Text File BuildTools.log.txt    
Version: git-BuildTools-7fe9375-122 (#122)
Guidelines Read: Yes

 Description   

compiling craftbukkit with `java -jar BuildTool.jar --rev 1.16.3 --compile craftbukkit` still performs the first (unnecessary) step of compiling spigot, that is applying the spigot-api patches and spigot-server patches to the codebase. I suggest these steps are removed from the build process when only CraftBukkit is being built.

 Comments   
Comment by md_5 [ 06/Feb/24 ]

https://hub.spigotmc.org/stash/projects/SPIGOT/repos/buildtools/commits/da67ff1ad2bc4752ebb3a08809729ae0f7a7873c#src%2Fmain%2Fjava%2Forg%2Fspigotmc%2Fbuilder%2FBuilder.java

Comment by Jan Boerman [ 19/Nov/20 ]

The problem is not that the compiled Craftbukkit jar includes Spigot's changes, the problem is that after Craftbukkit is compiled the Spigot patches are applied to the source code. This is makes the build process longer but it's a completely unnecessary step when Spigot isn't being compiled.

Comment by Airtheon Thesalion [ 12/Nov/20 ]

BuildTools is mainly for compiling Spigot. The option to compile CraftBukkit was added so just compiling Spigot wouldn't end with the unnecessary compiling of CraftBukkit. (Actually the steps are a little different, but I digress)
As this is the Spigot project, CraftBukkit is mostly used internally, while Spigot is the main product.

If you want to just compile CraftBukkit you can also clone the project and follow the build instructions in the README. With a proper IDE that is fairly straightforward.

Generated at Sat Dec 13 14:29:47 UTC 2025 using Jira 10.3.13#10030013-sha1:56dd970ae30ebfeda3a697d25be1f6388b68a422.