[Regression] Build failure for older MC revisions due to fix for BUILDTOOLS-301

    • Type: Bug
    • Resolution: Fixed
    • Priority: Minor
    • Environment:

      Any system where sh is not symbolic-linked to bash.

      As part of the fix for BUILDTOOLS-301, commit e2243e9cfc8 was applied to Spigot and 60cf7613510 was applied to BuildTools. However, given that e2243e9cfc8 was not backported to older versions of Spigot, attempting to build Spigot fails for any minecraft revision before 1.11.2.

      This issue is compounded by the fact that 60cf7613510 disrespects the SHELL environmental variable, making it impossible to build pre-1.11.2 versions with BuildTools after and including 60cf7613510 given that one can no longer instruct BuildTools to use bash.

      This issue can be resolved by either:

      • Backporting e2243e9cfc8 to all older revisions of minecraft.
      • Reverting 60cf7613510 to allow users to set the SHELL environmental variable to bash as necessary.
      • Adding special logic in BuildTools that selectively uses bash on older revisions.

          [BUILDTOOLS-305] [Regression] Build failure for older MC revisions due to fix for BUILDTOOLS-301

          md_5 added a comment -

          BuildTools will attempt to use SHELL or bash for older versions.

          My stance that you should use BuildTools versions of similar timeframes still stands.

          md_5 added a comment - BuildTools will attempt to use SHELL or bash for older versions. My stance that you should use BuildTools versions of similar timeframes still stands.

          md_5 added a comment -

          Options 1 or 2 are not really acceptable.

          My immediate response is that you should use BuildTools versions of similar age when attempting to build Minecraft versions.

          Adding logic to support older versions is a possibility, but I don't think it's a priority.

          md_5 added a comment - Options 1 or 2 are not really acceptable. My immediate response is that you should use BuildTools versions of similar age when attempting to build Minecraft versions. Adding logic to support older versions is a possibility, but I don't think it's a priority.

            Assignee:
            Unassigned
            Reporter:
            Amit Agnani
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: