{ "_class" : "hudson.model.FreeStyleBuild", "actions" : [ { "_class" : "hudson.model.CauseAction", "causes" : [ { "_class" : "hudson.triggers.SCMTrigger$SCMTriggerCause", "shortDescription" : "Started by an SCM change" } ] }, { }, { "_class" : "hudson.plugins.git.util.BuildData", "buildsByBranchName" : { "refs/remotes/origin/master" : { "_class" : "hudson.plugins.git.util.Build", "buildNumber" : 852, "buildResult" : None, "marked" : { "SHA1" : "19507baf8b7903427bc3efab7118de6e7c1c931e", "branch" : [ { "SHA1" : "19507baf8b7903427bc3efab7118de6e7c1c931e", "name" : "refs/remotes/origin/master" } ] }, "revision" : { "SHA1" : "19507baf8b7903427bc3efab7118de6e7c1c931e", "branch" : [ { "SHA1" : "19507baf8b7903427bc3efab7118de6e7c1c931e", "name" : "refs/remotes/origin/master" } ] } } }, "lastBuiltRevision" : { "SHA1" : "19507baf8b7903427bc3efab7118de6e7c1c931e", "branch" : [ { "SHA1" : "19507baf8b7903427bc3efab7118de6e7c1c931e", "name" : "refs/remotes/origin/master" } ] }, "remoteUrls" : [ "https://hub.spigotmc.org/stash/scm/spigot/craftbukkit.git" ], "scmName" : "" }, { "_class" : "hudson.plugins.git.GitTagAction" }, { }, { "_class" : "org.jenkinsci.plugins.displayurlapi.actions.RunDisplayAction" } ], "artifacts" : [ ], "building" : False, "description" : None, "displayName" : "#852", "duration" : 325, "estimatedDuration" : 590, "executor" : None, "fullDisplayName" : "CraftBukkit-RSS #852", "id" : "852", "inProgress" : False, "keepLog" : False, "number" : 852, "queueId" : 158, "result" : "SUCCESS", "timestamp" : 1501907946733, "url" : "https://hub.spigotmc.org/jenkins/view/RSS/job/CraftBukkit-RSS/852/", "builtOn" : "", "changeSet" : { "_class" : "hudson.plugins.git.GitChangeSetList", "items" : [ { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/main/java/org/bukkit/craftbukkit/block/CraftEnderChest.java", "src/main/java/org/bukkit/craftbukkit/block/CraftEndGateway.java", "src/main/java/org/bukkit/craftbukkit/block/CraftNoteBlock.java", "src/main/java/org/bukkit/craftbukkit/block/CraftBlockState.java", "src/main/java/org/bukkit/craftbukkit/block/CraftLootable.java", "src/main/java/org/bukkit/craftbukkit/block/CraftFurnace.java", "src/main/java/org/bukkit/craftbukkit/block/CraftCreatureSpawner.java", "src/main/java/org/bukkit/craftbukkit/block/CraftBanner.java", "src/main/java/org/bukkit/craftbukkit/block/CraftJukebox.java", "src/main/java/org/bukkit/craftbukkit/block/CraftSign.java", "src/main/java/org/bukkit/craftbukkit/block/CraftChest.java", "src/main/java/org/bukkit/craftbukkit/block/CraftBed.java", "src/main/java/org/bukkit/craftbukkit/block/CraftBrewingStand.java", "src/main/java/org/bukkit/craftbukkit/block/CraftDropper.java", "src/main/java/org/bukkit/craftbukkit/block/CraftCommandBlock.java", "src/main/java/org/bukkit/craftbukkit/block/CraftBlockEntityState.java", "src/main/java/org/bukkit/craftbukkit/block/CraftEnchantingTable.java", "src/main/java/org/bukkit/craftbukkit/block/CraftContainer.java", "src/main/java/org/bukkit/craftbukkit/block/CraftHopper.java", "nms-patches/TileEntityBrewingStand.patch", "src/main/java/org/bukkit/craftbukkit/block/CraftDaylightDetector.java", "src/main/java/org/bukkit/craftbukkit/block/CraftShulkerBox.java", "src/main/java/org/bukkit/craftbukkit/block/CraftSkull.java", "src/main/java/org/bukkit/craftbukkit/block/CraftBlock.java", "src/main/java/org/bukkit/craftbukkit/block/CraftBeacon.java", "src/main/java/org/bukkit/craftbukkit/block/CraftDispenser.java", "nms-patches/TileEntityContainer.patch", "src/main/java/org/bukkit/craftbukkit/block/CraftStructureBlock.java", "src/main/java/org/bukkit/craftbukkit/block/CraftComparator.java", "src/main/java/org/bukkit/craftbukkit/inventory/CraftMetaBlockState.java", "src/main/java/org/bukkit/craftbukkit/block/CraftFlowerPot.java" ], "commitId" : "19507baf8b7903427bc3efab7118de6e7c1c931e", "timestamp" : 1501907839000, "author" : { "absoluteUrl" : "https://hub.spigotmc.org/jenkins/user/md_5", "fullName" : "md_5" }, "authorEmail" : "git@md-5.net", "comment" : "Improvements to BlockStates\u000a* Actually capture all the data of TileEntities. This is done by\u000acreating a copy of the TileEntity. The methods of BlockState which\u000acurrently directly access the TileEntity reference will modify the data\u000aof that TileEntity-snapshot instead.\u000a* With the call to BlockState.update, the captured TileEntity data gets\u000aapplied to the current TileEntity in the world.\u000a* Methods which trigger block specific actions will use the current\u000aTileEntity from the world.\u000a* CraftBlockState does not hand out the wrapped or the snapshot\u000aTileEntity directly. Instead, it provides an applyTo method to copy the\u000adata to a given TileEntity and a method to directly get a copy of the\u000aTileEntity NBT data represented by the BlockState. CraftMetaBlockState\u000awas updated to make use of that.\u000a* Added #getSnapshotInventory() to bukkit which allows modifiying the\u000acaptured inventory snapshots of containers.\u000a* Tried to clarify which methods only work if the BlockState is placed,\u000awhich methods require the block in the world to still be of the same\u000atype (methods which trigger actions), and that .getInventory() directly\u000amodifies the inventory of the block in the world if the BlockState is\u000aplaced and becomes invalid if the block type is changed.\u000aBackwards compatibility\u000a* If the BlockState acts as InventoryHolder, getInventory() will still\u000areturn the inventory directly backed by the TileEntity in the world\u000a(like before), and not the snapshot inventory. This compromise should\u000areduce the potential of these changes to break existing plugins, or\u000acraftbukkit's own use of BlockState.\u000a* The snapshot's inventory can be accessed by a new method\u000agetSnapshotInventory()\u000a* In case the BlockState is not placed (if it was retrieved from the\u000aMetaBlockState of an item), the getInventory() method will however\u000areturn the snapshot inventory. So that when the BlockState gets applied\u000aback to the item, the inventory changes are properly included.\u000a* With the changes to CraftMetaBlockState it is no longer required to\u000acall the update method before passing a modified BlockState to the\u000aCraftMetaBlockState. For backwards compatibility the update method will\u000asimply return true for a non-placed BlockState, without actually doing\u000aanything.\u000aImpact on plugins\u000a* Restoring blocks now actually works as expected, properly restoring\u000athe TileEntity data, reglardless if the block changed its type in the\u000ameantime.\u000a* Plugins are now consistently required to call the update method in\u000aorder to apply changes to blocks. Though, regarding the Javadoc they\u000ashould have been required to do so anyways.\u000a* New feature: Plugins can take and modify inventory snapshots.\u000a* Breaking change: If a plugin gets the BlockState of a block in the\u000aworld, modifies the inventory returned by .getInventory(), and then\u000atries to use the same BlockState to apply the TileEntity data to an\u000aItemStack block meta, the ItemStack will use the snapshot inventory,\u000adisregarding the changes made to the inventory returned by\u000a.getInventory(). This is the compromise of .getInventory() returning the\u000ainventory directly backed by the TileEntity in the world.\u000aOther fixes related to BlockState:\u000a* TileEntityContainer#getLocation() will run into a NPE if the\u000aTileEntity is non-placed (ex. when getting the BlockState from a\u000aCraftMetaBlockState).\u000a* Beacon.getEntitiesInRange() would previously throw a NPE if called for\u000aa non-placed BlockState. It was changed to now require to be placed and\u000ause the current TileEntity in the world. If the TileEntity in the world\u000ais no longer a beacon, it will return an empty list.\u000a* EndGateway now supports setting and getting the exit location even for\u000anon-placed EndGateways (inside BlockStateMeta) by using / returning a\u000alocation with world being null.\u000a", "date" : "2017-08-05 14:37:19 +1000", "id" : "19507baf8b7903427bc3efab7118de6e7c1c931e", "msg" : "Improvements to BlockStates", "paths" : [ { "editType" : "edit", "file" : "src/main/java/org/bukkit/craftbukkit/block/CraftContainer.java" }, { "editType" : "edit", "file" : "src/main/java/org/bukkit/craftbukkit/block/CraftStructureBlock.java" }, { "editType" : "edit", "file" : "src/main/java/org/bukkit/craftbukkit/block/CraftComparator.java" }, { "editType" : "edit", "file" : "src/main/java/org/bukkit/craftbukkit/block/CraftDispenser.java" }, { "editType" : "add", "file" : "src/main/java/org/bukkit/craftbukkit/block/CraftBlockEntityState.java" }, { "editType" : "edit", "file" : "src/main/java/org/bukkit/craftbukkit/block/CraftDaylightDetector.java" }, { "editType" : "edit", "file" : "nms-patches/TileEntityContainer.patch" }, { "editType" : "edit", "file" : "nms-patches/TileEntityBrewingStand.patch" }, { "editType" : "edit", "file" : "src/main/java/org/bukkit/craftbukkit/block/CraftCommandBlock.java" }, { "editType" : "edit", "file" : "src/main/java/org/bukkit/craftbukkit/block/CraftSkull.java" }, { "editType" : "edit", "file" : "src/main/java/org/bukkit/craftbukkit/block/CraftBlockState.java" }, { "editType" : "edit", "file" : "src/main/java/org/bukkit/craftbukkit/block/CraftCreatureSpawner.java" }, { "editType" : "edit", "file" : "src/main/java/org/bukkit/craftbukkit/block/CraftShulkerBox.java" }, { "editType" : "edit", "file" : "src/main/java/org/bukkit/craftbukkit/block/CraftEnderChest.java" }, { "editType" : "edit", "file" : "src/main/java/org/bukkit/craftbukkit/block/CraftBrewingStand.java" }, { "editType" : "edit", "file" : "src/main/java/org/bukkit/craftbukkit/block/CraftBanner.java" }, { "editType" : "edit", "file" : "src/main/java/org/bukkit/craftbukkit/block/CraftBeacon.java" }, { "editType" : "edit", "file" : "src/main/java/org/bukkit/craftbukkit/block/CraftDropper.java" }, { "editType" : "edit", "file" : "src/main/java/org/bukkit/craftbukkit/block/CraftNoteBlock.java" }, { "editType" : "edit", "file" : "src/main/java/org/bukkit/craftbukkit/block/CraftBed.java" }, { "editType" : "edit", "file" : "src/main/java/org/bukkit/craftbukkit/block/CraftBlock.java" }, { "editType" : "edit", "file" : "src/main/java/org/bukkit/craftbukkit/block/CraftHopper.java" }, { "editType" : "edit", "file" : "src/main/java/org/bukkit/craftbukkit/inventory/CraftMetaBlockState.java" }, { "editType" : "edit", "file" : "src/main/java/org/bukkit/craftbukkit/block/CraftChest.java" }, { "editType" : "edit", "file" : "src/main/java/org/bukkit/craftbukkit/block/CraftFurnace.java" }, { "editType" : "edit", "file" : "src/main/java/org/bukkit/craftbukkit/block/CraftLootable.java" }, { "editType" : "edit", "file" : "src/main/java/org/bukkit/craftbukkit/block/CraftFlowerPot.java" }, { "editType" : "edit", "file" : "src/main/java/org/bukkit/craftbukkit/block/CraftJukebox.java" }, { "editType" : "edit", "file" : "src/main/java/org/bukkit/craftbukkit/block/CraftSign.java" }, { "editType" : "edit", "file" : "src/main/java/org/bukkit/craftbukkit/block/CraftEndGateway.java" }, { "editType" : "edit", "file" : "src/main/java/org/bukkit/craftbukkit/block/CraftEnchantingTable.java" } ] } ], "kind" : "git" }, "culprits" : [ { "absoluteUrl" : "https://hub.spigotmc.org/jenkins/user/md_5", "fullName" : "md_5" } ] }