{
  "_class" : "hudson.model.FreeStyleBuild",
  "actions" : [
    {
      "_class" : "hudson.model.CauseAction",
      "causes" : [
        {
          "_class" : "hudson.triggers.SCMTrigger$SCMTriggerCause",
          "shortDescription" : "Started by an SCM change"
        }
      ]
    },
    {
      
    },
    {
      "_class" : "hudson.plugins.git.util.BuildData",
      "buildsByBranchName" : {
        "refs/remotes/origin/master" : {
          "_class" : "hudson.plugins.git.util.Build",
          "buildNumber" : 1792,
          "buildResult" : None,
          "marked" : {
            "SHA1" : "1b2830a3b3aa5ecf4d2f44696654fc028a2c53a0",
            "branch" : [
              {
                "SHA1" : "1b2830a3b3aa5ecf4d2f44696654fc028a2c53a0",
                "name" : "refs/remotes/origin/master"
              }
            ]
          },
          "revision" : {
            "SHA1" : "1b2830a3b3aa5ecf4d2f44696654fc028a2c53a0",
            "branch" : [
              {
                "SHA1" : "1b2830a3b3aa5ecf4d2f44696654fc028a2c53a0",
                "name" : "refs/remotes/origin/master"
              }
            ]
          }
        }
      },
      "lastBuiltRevision" : {
        "SHA1" : "1b2830a3b3aa5ecf4d2f44696654fc028a2c53a0",
        "branch" : [
          {
            "SHA1" : "1b2830a3b3aa5ecf4d2f44696654fc028a2c53a0",
            "name" : "refs/remotes/origin/master"
          }
        ]
      },
      "remoteUrls" : [
        "https://hub.spigotmc.org/stash/scm/spigot/craftbukkit.git"
      ],
      "scmName" : ""
    },
    {
      "_class" : "hudson.plugins.git.GitTagAction"
    },
    {
      
    },
    {
      "_class" : "org.jenkinsci.plugins.displayurlapi.actions.RunDisplayAction"
    }
  ],
  "artifacts" : [
    
  ],
  "building" : False,
  "description" : None,
  "displayName" : "#1792",
  "duration" : 702,
  "estimatedDuration" : 590,
  "executor" : None,
  "fullDisplayName" : "CraftBukkit-RSS #1792",
  "id" : "1792",
  "inProgress" : False,
  "keepLog" : False,
  "number" : 1792,
  "queueId" : 508,
  "result" : "SUCCESS",
  "timestamp" : 1591003505588,
  "url" : "https://hub.spigotmc.org/jenkins/view/RSS/job/CraftBukkit-RSS/1792/",
  "builtOn" : "",
  "changeSet" : {
    "_class" : "hudson.plugins.git.GitChangeSetList",
    "items" : [
      {
        "_class" : "hudson.plugins.git.GitChangeSet",
        "affectedPaths" : [
          "src/main/java/org/bukkit/craftbukkit/inventory/CraftMetaItem.java",
          "src/main/java/org/bukkit/craftbukkit/entity/CraftPlayer.java",
          "src/main/java/org/bukkit/craftbukkit/entity/CraftEntity.java",
          "src/test/java/org/bukkit/craftbukkit/util/CraftChatMessageTest.java",
          "nms-patches/PlayerConnection.patch",
          "src/main/java/org/bukkit/craftbukkit/util/CraftChatMessage.java",
          "src/main/java/org/bukkit/craftbukkit/inventory/CraftMetaBook.java"
        ],
        "commitId" : "1b2830a3b3aa5ecf4d2f44696654fc028a2c53a0",
        "timestamp" : 1591003182000,
        "author" : {
          "absoluteUrl" : "https://hub.spigotmc.org/jenkins/user/md_5",
          "fullName" : "md_5"
        },
        "authorEmail" : "git@md-5.net",
        "comment" : "SPIGOT-4441: Fix serializing Components to and from Legacy\u000a\u000aWhile cfeef75cd97 might of semi helped being able to save black text\u000alore, it actually took a fundamental problem with the legacy serialization\u000acode and expanded it to break even more aspects of the server when dealing\u000awith Component to Legacy conversion.\u000a\u000aThis is causing data loss in Spigot with cases such as setting an item name\u000ato white gets stripped resulting in it being italic.\u000a\u000aAdditionally, things such as book pages have been returning black formatting\u000acodes for the end of the line even when the user doesn't have colors in the book.\u000a\u000aThe root issue is that the \"Default Color\" system is fundamentally wrong.\u000a\u000aComponents do not and should not care about what element of the game they\u000aare being used by, and that's what the default color system did.\u000a\u000aIt results in components that if obtained from 1 source such as a Book\u000awhere the default / rendered color is black, is then copied to another\u000asource such as an Entity name, the black is carried forward and shown\u000ain the Entity name, when in reality it should have been white.\u000a\u000aThis commit reverts cfeef75cd97 and fixes the underlying serialization\u000aissues when it comes to Legacy to and From conversions.\u000a\u000aThere was quite a number of issues with this code overall, in how\u000ait handles inserting color codes, new line parsing and such.\u000a\u000aBooks was using mojangs own \"getLegacyString\" which doesn't match behavior.\u000aWe also do not want to use Mojangs method as there is no guarantee they don't\u000aremove that in future.\u000aPlus, everything about books uses the CB implementation anyways, and it should\u000abe consistent (this was mandatory to avoid serialization format changes on old vs new)\u000a\u000aThese changes as is results in Item Stacks already serialized will not\u000achange contents when they go to component and back, so this won't impact\u000aany existing data.\u000a\u000aNewly created books though for example will change behavior in that they\u000awill no longer insert black color codes in the serialized data and will\u000aonly represent intentional color changes by the creator of the book.\u000aThis will result in cleaner data on them, and books are the only thing\u000aI'm aware of that has a behavioral shift due to the likelyhood of the\u000adefault color system kicking in on other parts of the string.\u000a\u000aA unit test has been added to verify integrity of serialization to\u000aensure that any legacy string that is converted into Components will\u000aalways re-encode back in the same way when going back to Legacy.\u000a",
        "date" : "2020-06-01 19:19:42 +1000",
        "id" : "1b2830a3b3aa5ecf4d2f44696654fc028a2c53a0",
        "msg" : "SPIGOT-4441: Fix serializing Components to and from Legacy",
        "paths" : [
          {
            "editType" : "edit",
            "file" : "src/main/java/org/bukkit/craftbukkit/inventory/CraftMetaItem.java"
          },
          {
            "editType" : "edit",
            "file" : "nms-patches/PlayerConnection.patch"
          },
          {
            "editType" : "edit",
            "file" : "src/main/java/org/bukkit/craftbukkit/util/CraftChatMessage.java"
          },
          {
            "editType" : "add",
            "file" : "src/test/java/org/bukkit/craftbukkit/util/CraftChatMessageTest.java"
          },
          {
            "editType" : "edit",
            "file" : "src/main/java/org/bukkit/craftbukkit/entity/CraftPlayer.java"
          },
          {
            "editType" : "edit",
            "file" : "src/main/java/org/bukkit/craftbukkit/inventory/CraftMetaBook.java"
          },
          {
            "editType" : "edit",
            "file" : "src/main/java/org/bukkit/craftbukkit/entity/CraftEntity.java"
          }
        ]
      }
    ],
    "kind" : "git"
  },
  "culprits" : [
    {
      "absoluteUrl" : "https://hub.spigotmc.org/jenkins/user/md_5",
      "fullName" : "md_5"
    }
  ]
}