002testReporthttps://hub.spigotmc.org/jenkins/job/BungeeCord/net.md-5$bungeecord-api/916/mavenArtifacts/false#9161617812390BungeeCord » BungeeCord-API #9162014-06-11_02-10-08falsefalse916-1SUCCESS1402467008000https://hub.spigotmc.org/jenkins/job/BungeeCord/net.md-5$bungeecord-api/916/api/src/main/java/net/md_5/bungee/api/ServerPing.java107d6b011db98e549b401ae56daa01d2701ad2871402430960000https://hub.spigotmc.org/jenkins/user/md_5md_5git@md-5.netFix ServerPing NPE w/ String favicons Currently, passing a null favicon String to the ServerPing(Protocol, Players, String, String) constructor causes a NPE. However, passing a null `Favicon` object to the corresponding constructor does not cause one. Setting the favicon String using the setFavicon(String) method doesn't cause a NPE either. Therefore, the NPE thrown by the constructor is inconsistent and should be avoided. Please find a sample NPE here: http://newpaste.md-5.net/pmtqjc8vl (Note the `null` favicon) This PR changes the documented (unintended?) behaviour by adding a null check before passing the favicon String to the alternative `Favicon` object constructor. This makes the constructor consistent with the other one and the `setFavicon(String)` method. This also adds compatibility for old (made before Favicon API) plugins passing `null` favicon Strings (and expecting no favicon to be displayed instead of a NPE). Thanks! 2014-06-11T06:09:20+1000107d6b011db98e549b401ae56daa01d2701ad287Fix ServerPing NPE w/ String faviconseditapi/src/main/java/net/md_5/bungee/api/ServerPing.javahttps://hub.spigotmc.org/jenkins/user/md_5md_5https://hub.spigotmc.org/jenkins/job/BungeeCord/net.md-5$bungeecord-api/916/mavenArtifacts/