002testReportbungeecord-apibungeecord-api-1.7-20140611.061104-214-javadoc.jarjavadocbungeecord-api-1.7-SNAPSHOT-javadoc.jarnet.md-5fa546797f40a43300f61f76bb4318706javadoc1.7-20140611.061104-214bungeecord-apibungeecord-api-1.7-20140611.061104-214-sources.jarsourcesbungeecord-api-1.7-SNAPSHOT-sources.jarnet.md-5c565878d57749196bb06b3b8e5654badjava-source1.7-20140611.061104-214bungeecord-apibungeecord-api-1.7-20140611.061104-214.jarbungeecord-api-1.7-SNAPSHOT.jarnet.md-5c2f90399d46ff159d3a63ddef897ed5bjar1.7-20140611.061104-214916https://hub.spigotmc.org/jenkins/job/BungeeCord/net.md-5$bungeecord-api/916/bungeecord-apibungeecord-api-1.7-SNAPSHOT.pompom.xmlnet.md-5af4269ab8ccfd331a6eb13337e0c5b8epom1.7-SNAPSHOThttps://hub.spigotmc.org/jenkins/job/BungeeCord/net.md-5$bungeecord-api/916/mavenArtifacts/https://hub.spigotmc.org/jenkins/job/BungeeCord/916/net.md-5$bungeecord-api/artifacthttps://hub.spigotmc.org/jenkins/job/BungeeCord/net.md-5$bungeecord-api/changeshttps://hub.spigotmc.org/jenkins/job/BungeeCord/916/net.md-5$bungeecord-api/https://hub.spigotmc.org/jenkins/job/BungeeCord/916/net.md-5$bungeecord-api/testReportfalseBungeeCord-API1617812390BungeeCord » BungeeCord-API BungeeCord-API2014-06-11_02-10-08falsefalse916-1SUCCESS1402467008000https://hub.spigotmc.org/jenkins/job/BungeeCord/net.md-5$bungeecord-api/916/api/src/main/java/net/md_5/bungee/api/ServerPing.java107d6b011db98e549b401ae56daa01d2701ad2871402430960000https://hub.spigotmc.org/jenkins/user/md_5md_5git@md-5.netFix ServerPing NPE w/ String favicons Currently, passing a null favicon String to the ServerPing(Protocol, Players, String, String) constructor causes a NPE. However, passing a null `Favicon` object to the corresponding constructor does not cause one. Setting the favicon String using the setFavicon(String) method doesn't cause a NPE either. Therefore, the NPE thrown by the constructor is inconsistent and should be avoided. Please find a sample NPE here: http://newpaste.md-5.net/pmtqjc8vl (Note the `null` favicon) This PR changes the documented (unintended?) behaviour by adding a null check before passing the favicon String to the alternative `Favicon` object constructor. This makes the constructor consistent with the other one and the `setFavicon(String)` method. This also adds compatibility for old (made before Favicon API) plugins passing `null` favicon Strings (and expecting no favicon to be displayed instead of a NPE). Thanks! 2014-06-11T06:09:20+1000107d6b011db98e549b401ae56daa01d2701ad287Fix ServerPing NPE w/ String faviconseditapi/src/main/java/net/md_5/bungee/api/ServerPing.javahttps://hub.spigotmc.org/jenkins/user/md_5md_5md_5bungeecord-apibungeecord-api-1.7-20140611.061104-214-javadoc.jarjavadocbungeecord-api-1.7-SNAPSHOT-javadoc.jarnet.md-5fa546797f40a43300f61f76bb4318706javadoc1.7-20140611.061104-214bungeecord-apibungeecord-api-1.7-20140611.061104-214-sources.jarsourcesbungeecord-api-1.7-SNAPSHOT-sources.jarnet.md-5c565878d57749196bb06b3b8e5654badjava-source1.7-20140611.061104-214bungeecord-apibungeecord-api-1.7-20140611.061104-214.jarbungeecord-api-1.7-SNAPSHOT.jarnet.md-5c2f90399d46ff159d3a63ddef897ed5bjar1.7-20140611.061104-214916https://hub.spigotmc.org/jenkins/job/BungeeCord/net.md-5$bungeecord-api/916/bungeecord-apibungeecord-api-1.7-SNAPSHOT.pompom.xmlnet.md-5af4269ab8ccfd331a6eb13337e0c5b8epom1.7-SNAPSHOThttps://hub.spigotmc.org/jenkins/job/BungeeCord/net.md-5$bungeecord-api/916/mavenArtifacts/