<mavenModuleSetBuild _class='hudson.maven.MavenModuleSetBuild'><action _class='hudson.model.CauseAction'><cause _class='com.cloudbees.jenkins.GitHubPushCause'><shortDescription>Started by GitHub push by md-5</shortDescription></cause><cause _class='com.cloudbees.jenkins.GitHubPushCause'><shortDescription>Started by GitHub push by md-5</shortDescription></cause></action><action></action><action _class='hudson.plugins.git.util.BuildData'><buildsByBranchName><originmaster _class='hudson.plugins.git.util.Build'><buildNumber>916</buildNumber><marked><SHA1>107d6b011db98e549b401ae56daa01d2701ad287</SHA1><branch><SHA1>107d6b011db98e549b401ae56daa01d2701ad287</SHA1><name>origin/master</name></branch></marked><revision><SHA1>107d6b011db98e549b401ae56daa01d2701ad287</SHA1><branch><SHA1>107d6b011db98e549b401ae56daa01d2701ad287</SHA1><name>origin/master</name></branch></revision></originmaster></buildsByBranchName><lastBuiltRevision><SHA1>107d6b011db98e549b401ae56daa01d2701ad287</SHA1><branch><SHA1>107d6b011db98e549b401ae56daa01d2701ad287</SHA1><name>origin/master</name></branch></lastBuiltRevision><remoteUrl>git://github.com/SpigotMC/BungeeCord.git</remoteUrl><scmName></scmName></action><action _class='hudson.plugins.git.GitTagAction'></action><action></action><action _class='hudson.maven.reporters.MavenAggregatedArtifactRecord'></action><action _class='hudson.maven.reporters.SurefireAggregatedReport'><failCount>0</failCount><skipCount>0</skipCount><totalCount>19</totalCount><urlName>testReport</urlName></action><action></action><action _class='org.jenkinsci.plugins.displayurlapi.actions.RunDisplayAction'></action><artifact><displayPath>BungeeCord.jar</displayPath><fileName>BungeeCord.jar</fileName><relativePath>bootstrap/target/BungeeCord.jar</relativePath></artifact><artifact><displayPath>cmd_alert.jar</displayPath><fileName>cmd_alert.jar</fileName><relativePath>module/cmd-alert/target/cmd_alert.jar</relativePath></artifact><artifact><displayPath>cmd_find.jar</displayPath><fileName>cmd_find.jar</fileName><relativePath>module/cmd-find/target/cmd_find.jar</relativePath></artifact><artifact><displayPath>cmd_list.jar</displayPath><fileName>cmd_list.jar</fileName><relativePath>module/cmd-list/target/cmd_list.jar</relativePath></artifact><artifact><displayPath>cmd_send.jar</displayPath><fileName>cmd_send.jar</fileName><relativePath>module/cmd-send/target/cmd_send.jar</relativePath></artifact><artifact><displayPath>cmd_server.jar</displayPath><fileName>cmd_server.jar</fileName><relativePath>module/cmd-server/target/cmd_server.jar</relativePath></artifact><artifact><displayPath>reconnect_yaml.jar</displayPath><fileName>reconnect_yaml.jar</fileName><relativePath>module/reconnect-yaml/target/reconnect_yaml.jar</relativePath></artifact><building>false</building><displayName>#916</displayName><duration>112204</duration><estimatedDuration>162405</estimatedDuration><fullDisplayName>BungeeCord #916</fullDisplayName><id>2014-06-11_02-10-07</id><inProgress>false</inProgress><keepLog>false</keepLog><number>916</number><queueId>-1</queueId><result>SUCCESS</result><timestamp>1402467007000</timestamp><url>https://hub.spigotmc.org/jenkins/job/BungeeCord/916/</url><builtOn></builtOn><changeSet _class='hudson.plugins.git.GitChangeSetList'><item _class='hudson.plugins.git.GitChangeSet'><affectedPath>proxy/src/main/java/net/md_5/bungee/netty/PipelineUtils.java</affectedPath><commitId>f23691df232fcd7ae92d693a726fa1f053018ce8</commitId><timestamp>1402430913000</timestamp><author><absoluteUrl>https://hub.spigotmc.org/jenkins/user/md_5</absoluteUrl><fullName>md_5</fullName></author><authorEmail>git@md-5.net</authorEmail><comment>Reenable throttle since we only support 1.7+
</comment><date>2014-06-11T06:08:33+1000</date><id>f23691df232fcd7ae92d693a726fa1f053018ce8</id><msg>Reenable throttle since we only support 1.7+</msg><path><editType>edit</editType><file>proxy/src/main/java/net/md_5/bungee/netty/PipelineUtils.java</file></path></item><item _class='hudson.plugins.git.GitChangeSet'><affectedPath>api/src/main/java/net/md_5/bungee/api/ServerPing.java</affectedPath><commitId>107d6b011db98e549b401ae56daa01d2701ad287</commitId><timestamp>1402430960000</timestamp><author><absoluteUrl>https://hub.spigotmc.org/jenkins/user/md_5</absoluteUrl><fullName>md_5</fullName></author><authorEmail>git@md-5.net</authorEmail><comment>Fix ServerPing NPE w/ String favicons

Currently, passing a null favicon String to the ServerPing(Protocol, Players, String, String) constructor causes a NPE. However, passing a null `Favicon` object to the corresponding constructor does not cause one. Setting the favicon String using the setFavicon(String) method doesn't cause a NPE either.

Therefore, the NPE thrown by the constructor is inconsistent and should be avoided. Please find a sample NPE here: http://newpaste.md-5.net/pmtqjc8vl (Note the `null` favicon)

This PR changes the documented (unintended?) behaviour by adding a null check before passing the favicon String to the alternative `Favicon` object constructor. This makes the constructor consistent with the other one and the `setFavicon(String)` method. This also adds compatibility for old (made before Favicon API) plugins passing `null` favicon Strings (and expecting no favicon to be displayed instead of a NPE).

Thanks!
</comment><date>2014-06-11T06:09:20+1000</date><id>107d6b011db98e549b401ae56daa01d2701ad287</id><msg>Fix ServerPing NPE w/ String favicons</msg><path><editType>edit</editType><file>api/src/main/java/net/md_5/bungee/api/ServerPing.java</file></path></item><kind>git</kind></changeSet><culprit><absoluteUrl>https://hub.spigotmc.org/jenkins/user/md_5</absoluteUrl><fullName>md_5</fullName></culprit><mavenArtifacts></mavenArtifacts><mavenVersionUsed>3.0.4</mavenVersionUsed></mavenModuleSetBuild>